Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[math] Support TComplex arithmetic operations with any possible type #13746

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

guitargeek
Copy link
Contributor

Generalize the arithmetic operator overloads of TComplex to general arithmetic types with templates.

Closes #13730.

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

Generalize the arithmetic operator overloads of TComplex to general
arithmetic types with templates.

I'm using some `enable_if` for arithmetic types only, so we can be sure
that nothing unexpected will happen for non-arithmetic types that
implement arithmetic operators with `double` themselves.

Closes root-project#13730.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek guitargeek added this to the 6.30/00 milestone Sep 28, 2023
@phsft-bot
Copy link
Collaborator

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

@github-actions
Copy link

Test Results

         9 files           9 suites   2d 6h 23m 23s ⏱️
  2 477 tests   2 475 ✔️ 0 💤 2
21 366 runs  21 364 ✔️ 0 💤 2

For more details on these failures, see this check.

Results for commit 993cc13.

@guitargeek guitargeek merged commit fa46203 into root-project:master Oct 2, 2023
8 of 14 checks passed
@guitargeek guitargeek deleted the issue-13730 branch October 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[math] TComplex arithmetic operators don't work with integral types
3 participants